Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hack/benchmark search interface change #2129

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Fix hack/benchmark search interface change #2129

merged 2 commits into from
Jul 12, 2023

Conversation

kevindiu
Copy link
Contributor

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.16

Checklist:

Special notes for your reviewer:

@kevindiu
fix hack/benchmark search interface
4032547 
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
@kevindiu kevindiu requested review from a team, kpango and hlts2 and removed request for a team July 11, 2023 23:20
kpango
kpango previously approved these changes Jul 11, 2023
View reviewed changes
@github-actions github-actions bot added size/S type/bug Something isn't working labels Jul 11, 2023
@kevindiu kevindiu changed the title Fix hack/benchmark search error Fix hack/benchmark search interface change Jul 11, 2023
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kevindiu
change bit64 interface
82bd749 
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 11, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 82bd749
Status: ✅  Deploy successful!
Preview URL: https://867c2704.vald.pages.dev
Branch Preview URL: https://bugfix-hack-fix-search-ctx.vald.pages.dev

View logs

@kevindiu kevindiu requested a review from kpango July 11, 2023 23:26
@vankichi vankichi merged commit 38d537f into main Jul 12, 2023
@vankichi vankichi deleted the bugfix/hack/fix-search-ctx branch July 12, 2023 00:45
ykadowak pushed a commit that referenced this pull request Jul 25, 2023
@kevindiu @ykadowak
Fix hack/benchmark search interface change (#2129)
1b918b5
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Fix hack/benchmark search interface change (#2129)"
fbc5262 
This reverts commit 38d537f.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Fix hack/benchmark search interface change (#2129)"
340b2eb 
This reverts commit 38d537f.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Fix hack/benchmark search interface change (#2129)"
88b4c8c 
This reverts commit 38d537f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vankichi vankichi vankichi approved these changes

@kpango kpango kpango approved these changes

@hlts2 hlts2 Awaiting requested review from hlts2 hlts2 was automatically assigned from vdaas/maintainer

Assignees
No one assigned
Labels
priority/medium size/S type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevindiu @vdaas-ci @kpango @vankichi